xtern commented on code in PR #4927:
URL: https://github.com/apache/ignite-3/pull/4927#discussion_r1895854546
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##########
@@ -442,9 +443,10 @@ private AsyncDataCursor<InternalSqlRow>
executeExecutablePlan(
QueryTransactionWrapper txWrapper = txContext.explicitTx();
if (txWrapper == null) {
- // underlying table will initiate transaction by itself, but we
need stub to reuse
- // TxAwareAsyncCursor
- txWrapper = NoopTransactionWrapper.INSTANCE;
+ txWrapper = plan.transactional()
Review Comment:
Done
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ScannableTableImpl.java:
##########
@@ -221,7 +221,7 @@ public <RowT> Publisher<RowT> indexLookup(
@Override
public <RowT> CompletableFuture<RowT> primaryKeyLookup(
ExecutionContext<RowT> ctx,
- @Nullable InternalTransaction explicitTx,
+ InternalTransaction tx,
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
