xtern commented on code in PR #4927:
URL: https://github.com/apache/ignite-3/pull/4927#discussion_r1895855677
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/tx/QueryTransactionContext.java:
##########
@@ -24,8 +24,15 @@
* Context that allows to get explicit transaction provided by user or start
implicit one.
*/
public interface QueryTransactionContext {
- /** Returns explicit transaction or start implicit one. */
- QueryTransactionWrapper getOrStartImplicit(boolean readOnly);
+ /**
+ * Starts an implicit transaction if one has not been started previously
+ * and if there is no external (user-managed) transaction.
+ *
+ * @param readOnly Indicates whether the read-only transaction or
read-write transaction should be started.
+ * @param tableDriven Indicates whether the implicit transaction will be
managed by the table storage or the SQL engine.
+ * @return Transaction wrapper.
+ */
+ QueryTransactionWrapper getOrStartImplicit(boolean readOnly, boolean
tableDriven);
Review Comment:
Done, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
