JAkutenshi commented on code in PR #4446: URL: https://github.com/apache/ignite-3/pull/4446#discussion_r1871748723
########## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java: ########## @@ -319,7 +322,8 @@ public ReplicaManager( RaftManager raftManager, RaftGroupOptionsConfigurer partitionRaftConfigurer, LogStorageFactoryCreator volatileLogStorageFactoryCreator, - Executor replicaStartStopExecutor + Executor replicaStartStopExecutor, + Function<ReplicationGroupId, CompletableFuture<byte[]>> getPendingAssignmentsSupplier Review Comment: Done there in `ReplicaManager` and also `TestReplicaMetaImpl` had missed `@param`s, thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org