sanpwc commented on code in PR #4446:
URL: https://github.com/apache/ignite-3/pull/4446#discussion_r1871347545
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java:
##########
@@ -1298,6 +1319,93 @@ private CompletableFuture<Boolean>
onPrimaryExpired(PrimaryReplicaEventParameter
return falseCompletedFuture();
}
+ // TODO: move to Replica
https://issues.apache.org/jira/browse/IGNITE-23750
+ private void registerFailoverCallback(TablePartitionId
replicationGroupId) {
+ CompletableFuture<Replica> replicaFuture =
replicaManager.replica(replicationGroupId);
+
+ // TODO: https://issues.apache.org/jira/browse/IGNITE-23753
+ // For now we assume that it's a possible situation to get null
future on node's stopp process, but it should be fixed with
+ // a correct and consistent replica's state.
+ if (replicaFuture == null) {
+ return;
+ }
+
+ replicaFuture.thenApply(electedPrimaryReplica -> {
+ onLeaderElectedFailoverCallback = (leaderNode, term) ->
changePeersAndLearnersAsyncIfPendingExists(
+ electedPrimaryReplica,
+ replicationGroupId,
+ term
+ );
+
+ return
electedPrimaryReplica.raftClient().subscribeLeader(onLeaderElectedFailoverCallback);
+ }).exceptionally(e -> {
+ LOG.error("Rebalance failover subscription on elected primary
replica failed [groupId=" + replicationGroupId + "].", e);
+
+ return null;
+ });
+ }
+
+ // TODO: move to Replica
https://issues.apache.org/jira/browse/IGNITE-23750
+ private void unregisterFailoverCallback(PrimaryReplicaEventParameters
parameters) {
+ CompletableFuture<Replica> replicaFuture =
replicaManager.replica(parameters.groupId());
+
+ // TODO: https://issues.apache.org/jira/browse/IGNITE-23753
+ // For now we assume that it's a possible situation to get null
future on node's stopp process, but it should be fixed with
+ // a correct and consistent replica's state.
+ if (replicaFuture == null) {
+ return;
+ }
+
+ replicaFuture.thenAccept(expiredPrimaryReplica ->
expiredPrimaryReplica.raftClient()
+ .unsubscribeLeader(onLeaderElectedFailoverCallback)
+ );
+ }
+
+ private void changePeersAndLearnersAsyncIfPendingExists(
+ Replica primaryReplica,
+ TablePartitionId replicationGroupId,
+ long term
+ ) {
+
getPendingAssignmentsSupplier.apply(replicationGroupId).exceptionally(e -> {
+ LOG.error(
+ format(
Review Comment:
There's no need in using format, there's a `error(String msg, @Nullable
Throwable th, Object... params)` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
