sanpwc commented on code in PR #4446:
URL: https://github.com/apache/ignite-3/pull/4446#discussion_r1871192893
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java:
##########
@@ -1248,25 +1264,27 @@ void start(UUID localNodeId) {
}
private CompletableFuture<Boolean>
onPrimaryElected(PrimaryReplicaEventParameters parameters) {
- ReplicationGroupId groupId = parameters.groupId();
- ReplicaStateContext context = getContext(groupId);
+ TablePartitionId replicationGroupId = (TablePartitionId)
parameters.groupId();
Review Comment:
There's no need to convert abstract ReplicationGroupId to specific
TablePartitionId. ReplicaManager should be unaware of the specific type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
