denis-chudov commented on code in PR #4671: URL: https://github.com/apache/ignite-3/pull/4671#discussion_r1832452793
########## modules/core/src/main/java/org/apache/ignite/internal/causality/DeletionListener.java: ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.causality; + +/** + * Listener that will be notified of every deletion form a Versioned Value. + * + * @see VersionedValue#whenComplete(CompletionListener) + */ +public interface DeletionListener<T> { + /** + * Method that will be invoked on every deletion from a Versioned Value. + * + * @param tokenUpperBound Upper bound of the token up to which the Versioned Value was cleared (inclusive). + */ + void whenDelete(long tokenUpperBound); Review Comment: I would suggest `PruningListener` and `onPrune` because we not just remove/delete some version but clean all versions up to the given token. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
