sashapolo commented on code in PR #4671:
URL: https://github.com/apache/ignite-3/pull/4671#discussion_r1827396514


##########
modules/core/src/main/java/org/apache/ignite/internal/causality/IncrementalVersionedValue.java:
##########
@@ -161,6 +172,16 @@ public void removeWhenComplete(CompletionListener<T> 
action) {
         versionedValue.removeWhenComplete(action);
     }
 
+    @Override
+    public void whenDelete(DeletionListener<T> action) {
+        versionedValue.whenDelete(action);
+    }
+
+    @Override
+    public void removeWhenDelete(DeletionListener<T> action) {

Review Comment:
   I agree with you. I would suggest to rename both, but it's up to you



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to