sashapolo commented on code in PR #4671:
URL: https://github.com/apache/ignite-3/pull/4671#discussion_r1827408294


##########
modules/core/src/main/java/org/apache/ignite/internal/causality/BaseVersionedValue.java:
##########
@@ -341,4 +369,37 @@ private void notifyCompletionListeners(long 
causalityToken, CompletableFuture<T>
             }
         });
     }
+
+    /**
+     * Deletes all versions from the Version Value up to and including the 
{@code causalityToken} and notify all
+     * {@link #whenDelete(DeletionListener) registered deletion listeners}.
+     *
+     * <p>{@code causalityToken} is expected to be less than the last {@link 
#complete completed} and greater than the last deleted.</p>
+     *
+     * @param causalityToken Causality token.
+     */
+    void delete(long causalityToken) {

Review Comment:
   It should be called `deleteUpTo` then



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to