lowka commented on code in PR #4256: URL: https://github.com/apache/ignite-3/pull/4256#discussion_r1777994608
########## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/MinimumRequiredTimeCollectorService.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.table.distributed.raft; + +import java.util.Map; +import org.apache.ignite.internal.replicator.TablePartitionId; + +/** Collects minimum required timestamp for each partition. */ +public interface MinimumRequiredTimeCollectorService { + + /** Undefined value of a min timestamp. */ + long UNDEFINED_MIN_TIME = 0; + + /** Registers a partition. */ + void addPartition(TablePartitionId tablePartitionId); + + /** Records the given timestamp .*/ + void recordMinActiveTxTimestamp(TablePartitionId tablePartitionId, long timestamp); + + /** Remove timestamps associated with the given partition .*/ + void removePartition(TablePartitionId tablePartitionId); + + /** Returns a snapshot of collected timestamps. */ + Map<TablePartitionId, Long> minTimestampPerPartition(); Review Comment: This component only deals with `TablePartitionId` and callers of this method check their `TablePartitionId`s with results of this method. ########## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/MinimumRequiredTimeCollectorService.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.table.distributed.raft; + +import java.util.Map; +import org.apache.ignite.internal.replicator.TablePartitionId; + +/** Collects minimum required timestamp for each partition. */ +public interface MinimumRequiredTimeCollectorService { + + /** Undefined value of a min timestamp. */ + long UNDEFINED_MIN_TIME = 0; + + /** Registers a partition. */ + void addPartition(TablePartitionId tablePartitionId); + + /** Records the given timestamp .*/ + void recordMinActiveTxTimestamp(TablePartitionId tablePartitionId, long timestamp); + + /** Remove timestamps associated with the given partition .*/ + void removePartition(TablePartitionId tablePartitionId); + + /** Returns a snapshot of collected timestamps. */ + Map<TablePartitionId, Long> minTimestampPerPartition(); + + /** Closes this service. */ + void close(); Review Comment: We should. Done. ########## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/MinimumRequiredTimeCollectorService.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.table.distributed.raft; + +import java.util.Map; +import org.apache.ignite.internal.replicator.TablePartitionId; + +/** Collects minimum required timestamp for each partition. */ +public interface MinimumRequiredTimeCollectorService { + Review Comment: Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
