lowka commented on code in PR #4256:
URL: https://github.com/apache/ignite-3/pull/4256#discussion_r1774543917
##########
modules/catalog-compaction/src/main/java/org/apache/ignite/internal/catalog/compaction/CatalogManagerCompactionFacade.java:
##########
@@ -84,6 +86,22 @@ Int2IntMap collectTablesWithPartitionsBetween(long
minTsInclusive, long maxTsInc
}
}
+ /**
+ * Returns the catalog version that is active at the given timestamp.
+ *
+ * @param timestamp Timestamp.
+ * @return Catalog revision or {@code null} if such version of the catalog
doesn't exist.
+ */
+ @Nullable Catalog catalogAtTsNullable(long timestamp) {
Review Comment:
This method should be called `catalogAtTs()` it should never return null,
because its invocations are always followed by not null checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
