lowka commented on code in PR #4256:
URL: https://github.com/apache/ignite-3/pull/4256#discussion_r1773597789
##########
modules/catalog-compaction/src/main/java/org/apache/ignite/internal/catalog/compaction/CatalogCompactionRunner.java:
##########
@@ -335,9 +358,11 @@ CompletableFuture<TimeHolder>
determineGlobalMinimumRequiredTime(
if (response.minimumActiveTxTime() <
globalMinimumActiveTxTime) {
globalMinimumActiveTxTime =
response.minimumActiveTxTime();
}
+
+ remotePartitions.put(nodeId,
availablePartitionListToMap(response.partitions()));
}
- return new TimeHolder(globalMinimumRequiredTime,
globalMinimumActiveTxTime);
+ return new TimeHolder(globalMinimumRequiredTime,
globalMinimumActiveTxTime, remotePartitions);
Review Comment:
Fixed.
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java:
##########
@@ -714,10 +713,18 @@ private void
handleUpdateMinimalActiveTxTimeCommand(UpdateMinimumActiveTxBeginTi
}
long minActiveTxBeginTime0 = minActiveTxBeginTime;
+ long timestamp = cmd.timestamp();
- assert minActiveTxBeginTime0 <= cmd.timestamp() : "maxTime=" +
minActiveTxBeginTime0 + ", cmdTime=" + cmd.timestamp();
+ assert minActiveTxBeginTime0 <= timestamp : "maxTime=" +
minActiveTxBeginTime0 + ", cmdTime=" + timestamp;
- minActiveTxBeginTime = cmd.timestamp();
+ storage.flush(false).whenComplete((r, t) -> {
+ synchronized (this) {
+ long minActiveTxBeginTime1 = minActiveTxBeginTime;
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
