xiaobaicai66695 commented on code in PR #3699:
URL: https://github.com/apache/dubbo-go/pull/3699#discussion_r3841404769
##########
Makefile:
##########
@@ -83,6 +83,9 @@ test-race: clean ## Run unit tests with the race detector
$(GO_RUN) test ./... -race -skip '^($(subst
$(space),|,$(RACE_SKIP_TESTS)))$$' -coverprofile=$(CURDIR)/$(COVERAGE_FILE)
-covermode=atomic
cd $(CLI_DIR) && $(GO_RUN) test ./... -race
+generate-mocks: ## Regenerate GoMock implementations with the pinned generator
+ $(GO_RUN) generate ./cluster/metrics ./filter ./protocol/base
Review Comment:
It is not strictly necessary. It was added only as a discoverable shortcut
for regenerating the mocks, while the pinned `go:generate` directives already
make `go generate ./...` sufficient. After reconsidering, this command does not
appear to play a significant role in the regular development or testing
workflow, so I removed it in eb781c74.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
