xiaobaicai66695 commented on code in PR #3699:
URL: https://github.com/apache/dubbo-go/pull/3699#discussion_r3841271842
##########
tools/dubbogo-cli/cmd/gen_test.go:
##########
@@ -95,6 +95,21 @@ func TestGeneratedProjectsIncludeDependencyLocks(t
*testing.T) {
}
}
+func TestGeneratedProjectsDoNotIncludeLegacyMockDependency(t *testing.T) {
+ const legacyMockDependency = "github.com/golang/mock"
+
+ for _, tc := range generatedProjectCases() {
+ t.Run(tc.name, func(t *testing.T) {
+ genPath := filepath.Join(t.TempDir(), tc.name)
+ require.NoError(t, tc.generate(genPath))
+
+ content, err := os.ReadFile(filepath.Join(genPath,
"go.sum"))
+ require.NoError(t, err)
+ require.NotContains(t, string(content),
legacyMockDependency)
+ })
+ }
+}
Review Comment:
Removed the redundant scaffold dependency test in 85a44d8d. The generated
go.sum cleanup remains covered by the existing golden-file generation tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
