xiaobaicai66695 opened a new pull request, #3699:
URL: https://github.com/apache/dubbo-go/pull/3699
### Description
This PR implements the github.com/golang/mock migration from #3693.
- replace all dubbo-go GoMock imports with go.uber.org/mock/gomock
- pin MockGen v0.6.0 in go:generate directives and add make generate-mocks
- regenerate all five MockGen outputs with a reusable ASF license header
- remove github.com/golang/mock as a direct dependency and add
go.uber.org/mock v0.6.0
- remove legacy mock checksums from generated CLI scaffolds and add a
regression test
The old module remains indirect because github.com/dubbogo/gost and
github.com/nacos-group/nacos-sdk-go/v2 still import it. There are no direct
dubbo-go source imports left.
### Verification
- make fmt
- make check-fmt
- make generate-mocks twice; generated diff remained stable
- affected package tests passed
- affected package race tests passed
- go vet ./... passed in the root module and tools/dubbogo-cli
- tools/dubbogo-cli: go test ./... passed
- root make test: every package passed except two
environment/platform-specific packages
- remoting/etcdv3 expects no service on 127.0.0.1:2379, but a local etcd
is running
- protocol/triple/triple_protocol has new develop-branch assertions that
only recognize Unix EADDRINUSE errors
- both exceptional packages passed in an isolated Linux Go 1.25 container:
- go test ./protocol/triple/triple_protocol ./remoting/etcdv3 -count=1
### Checklist
- [x] I confirm the target branch is develop
- [x] I have run make fmt to format my code
- [x] I have run make test to run local tests
- [x] I have added tests that prove my fix is effective
Refs #3693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
