marsevilspirit commented on code in PR #2900:
URL: https://github.com/apache/dubbo-go/pull/2900#discussion_r2113179330


##########
protocol/options.go:
##########
@@ -27,20 +27,84 @@ import (
        "dubbo.apache.org/dubbo-go/v3/protocol/triple"
 )
 
-type Options struct {
+type ClientOption interface {
+       applyToClient(*ClientOptions)
+}
+
+type ServerOption interface {
+       applyToServer(*ServerOptions)
+}
+
+type Option interface {
+       ClientOption
+       ServerOption
+}
+
+// WithClientOptions composes multiple ClientOptions into one.
+func WithClientOptions(options ...ClientOption) ClientOption {
+       return &clientOptionsOption{options}
+}
+
+type clientOptionsOption struct {
+       options []ClientOption

Review Comment:
   Oops, it's a typo mistake, I will fix it soon.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to