marsevilspirit commented on code in PR #2900:
URL: https://github.com/apache/dubbo-go/pull/2900#discussion_r2114170478
##########
protocol/triple/server.go:
##########
@@ -54,18 +55,18 @@ import (
// provide functionality.
type Server struct {
triServer *tri.Server
- cfg *ServerOptions
+ cfg *global.TripleConfig
mu sync.RWMutex
services map[string]grpc.ServiceInfo
}
// NewServer creates a new TRIPLE server.
// triServer would not be initialized since we could not get configurations
here.
-func NewServer(opts ...ServerOption) *Server {
- newSrvOpts := defaultServerOptions()
- newSrvOpts.init(opts...)
+// NOTE: Now everything changed, we can initialized triServer now.
Review Comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
