marsevilspirit commented on code in PR #2900:
URL: https://github.com/apache/dubbo-go/pull/2900#discussion_r2113171613
##########
common/constant/default.go:
##########
@@ -28,7 +28,10 @@ const (
OverrideProtocol = "override" //compatible with 2.6.x
EmptyProtocol = "empty"
RouterProtocol = "router"
+ DubboProtocol = "dubbo"
Review Comment:
I believe that Dubbo and DubboProtocol are different concepts.
One is the name of our community, and the other is the name of the protocol.
Using the community's name as the name of the protocol, although the effect
is the same, creates a rather strange feeling.
I have some hesitation about how to handle this aspect, but from my
perspective, this is better than before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
