ctubbsii commented on code in PR #5433:
URL: https://github.com/apache/accumulo/pull/5433#discussion_r2019415558
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java:
##########
@@ -1511,15 +1511,13 @@ private void changeTableState(String tableName, boolean
wait, TableState newStat
switch (newState) {
case OFFLINE:
op = TFateOperation.TABLE_OFFLINE;
- if (tableName.equals(AccumuloTable.METADATA.tableName())
- || tableName.equals(AccumuloTable.ROOT.tableName())) {
- throw new AccumuloException("Cannot set table to offline state");
- }
+ NOT_BUILTIN_TABLE.validate(tableName);
Review Comment:
Maybe this could be optimized using the `AccumuloTable` class, and have a
`contains` method on it? To see if it's a built-in system table in the
`accumulo` namespace. I also saw that there was a possibility that the scan ref
table could actually be deleted, so it may not be safe to assume these tables
are always existing. Since this is just an optimization, to short-circuit a
check for built-in tables that should always exist, then it might be okay to
just check these metadata tables and do the longer check for everything else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
