kevinrr888 commented on code in PR #5433:
URL: https://github.com/apache/accumulo/pull/5433#discussion_r2027563314
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java:
##########
@@ -1511,15 +1511,13 @@ private void changeTableState(String tableName, boolean
wait, TableState newStat
switch (newState) {
case OFFLINE:
op = TFateOperation.TABLE_OFFLINE;
- if (tableName.equals(AccumuloTable.METADATA.tableName())
- || tableName.equals(AccumuloTable.ROOT.tableName())) {
- throw new AccumuloException("Cannot set table to offline state");
- }
+ NOT_BUILTIN_TABLE.validate(tableName);
Review Comment:
In a separate discussion, I had mentioned to you directly @ctubbsii in
regards to
> in 2.1, can online/offline any table that's not the ROOT table, can
deleteRows of any table that's not the METADATA table, and can bulkImportv2 any
table that's not the ROOT table.
That I was wrong about `offline` here, but I was thinking of `deleteRows`.
So here is the corrected statement:
> in 2.1, can online/offline any table that's not the ROOT table, can
deleteRows of any table that's not **a** METADATA table (METADATA, ROOT) (so
this is correct in 2.1), and can bulkImportV2 to any table that's not the ROOT
table
Since you shouldn't be able to `offline` any system table through the table
ops API, will change this PR to target 2.1.
This PR only pertains to `offline` so discussion around the other ops will
be pushed to other tickets/PRs most likely as discussion in the PR I make for
https://github.com/apache/accumulo/issues/5427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
