kevinrr888 commented on code in PR #5433:
URL: https://github.com/apache/accumulo/pull/5433#discussion_r2018834844
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java:
##########
@@ -1511,15 +1511,13 @@ private void changeTableState(String tableName, boolean
wait, TableState newStat
switch (newState) {
case OFFLINE:
op = TFateOperation.TABLE_OFFLINE;
- if (tableName.equals(AccumuloTable.METADATA.tableName())
- || tableName.equals(AccumuloTable.ROOT.tableName())) {
- throw new AccumuloException("Cannot set table to offline state");
- }
+ NOT_BUILTIN_TABLE.validate(tableName);
Review Comment:
Or, I'm wondering if it would be better to move all validation for the table
names (e.g., ensuring it's not a system table, ensuring the table exists,
doesn't exists, etc.) into `TableOperationsImpl`. Seems like some things are
validated in `TableOperationsImpl` and some are validated in
`FateServiceHandler` or both, which is a bit confusing. If we always validate
in `TableOperationsImpl` we can avoid the RPC. For example, if a user tried to
`delete` a system table, we know that shouldn't work before the RPC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
