ctubbsii commented on code in PR #5433:
URL: https://github.com/apache/accumulo/pull/5433#discussion_r2017693251
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java:
##########
@@ -1511,15 +1511,13 @@ private void changeTableState(String tableName, boolean
wait, TableState newStat
switch (newState) {
case OFFLINE:
op = TFateOperation.TABLE_OFFLINE;
- if (tableName.equals(AccumuloTable.METADATA.tableName())
- || tableName.equals(AccumuloTable.ROOT.tableName())) {
- throw new AccumuloException("Cannot set table to offline state");
- }
+ NOT_BUILTIN_TABLE.validate(tableName);
Review Comment:
Previously, this would have thrown an `AccumuloException`. Now it throws an
`IllegalArgumentException`. This is user-facing client side behavior. I think
`IllegalArgumentException` is okay here, but I would be curious to know what
the 2.1 behavior did before merging this to determine if it's an acceptable
change in behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
