Corinna Vinschen <vinsc...@redhat.com> : [...] > That won't happen with the current patch because only > rtl8169_reset_counters would print a log message, it's only called from > open, and open occurs rather seldom. Atop of that the code only tries > to reset counters on HW supporting it, and only if resetting on the HW > fails, there will be a log message at all. There's no reasonable chance > that failing to reset the counters will lead to log flooding.
Thanks for reformulating it. We are in violent agreement here. [...] > I'm not trying to avoid work, I'm trying to understand. > > As far as I see it failing to reset the counters has no impact on the > viability of the code. It's still working with offsets and if the > offset is 0 or non-0, the user space won't see the difference in the > values returned by @get_stats64. Successful resetting the counters is > just a bonus. Sorry, my english was really bad: the code should propagate failure when rtl8169_reset_counters and rtl8169_update_counters *simultaneously* fail. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
