David Miller <da...@davemloft.net> : [...] > Your counter offsets should be read at probe time, not open time.
It can be done but the "CmdRxEnb / rx traffic must be enabled" constraint will make it a major pita. Reading counter offsets at the end of open() naturally solves this constraint (retentive error unwinding in opne() stops being completely trivial though :o/ ). > Bringing the interface is brought down/up should not reset the > counters. Afaiks rtl8169_tc_offsets.inited in rtl8169_init_counter_offsets takes care of it: it's set during the first open() after probe(). Looking at it again, the patch directly stores 16 and 32 bit values in rtnl_link_stats64. Nobody should care about exact exceedingly high error count but rx_multicast ought to be accumulated. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
