On Mon, Jan 11, 2021 at 02:06:57PM +0100, Bjarni Jonasson wrote: > Add support for 100Base-FX, 100Base-LX, 100Base-PX and 100Base-BX10 modules > This is needed for Sparx-5 switch. > > Signed-off-by: Bjarni Jonasson <bjarni.jonas...@microchip.com> > --- > drivers/net/phy/sfp-bus.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/net/phy/sfp-bus.c b/drivers/net/phy/sfp-bus.c > index 58014feedf6c..b2a9ee3dd28e 100644 > --- a/drivers/net/phy/sfp-bus.c > +++ b/drivers/net/phy/sfp-bus.c > @@ -265,6 +265,12 @@ void sfp_parse_support(struct sfp_bus *bus, const struct > sfp_eeprom_id *id, > br_min <= 1300 && br_max >= 1200) > phylink_set(modes, 1000baseX_Full); > > + /* 100Base-FX, 100Base-LX, 100Base-PX, 100Base-BX10 */ > + if (id->base.e100_base_fx || id->base.e100_base_lx) > + phylink_set(modes, 100baseFX_Full); > + if ((id->base.e_base_px || id->base.e_base_bx10) && br_nom == 100) > + phylink_set(modes, 100baseFX_Full);
Do you have any modules that identify as PX or BX10 modules? What if their range of speeds covers 100M - you're only checking the nominal speed here. Note that this will likely conflict with changes I submitted over the weekend, and it really needs to be done _before_ the comment about "If we haven't discovered any modes", not below. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
