On Fri, 18 Sep 2020 20:09:24 +0000 Parav Pandit wrote: > > From: Jakub Kicinski <k...@kernel.org> > > Sent: Friday, September 18, 2020 11:58 PM > > > > On Fri, 18 Sep 2020 17:47:24 +0000 Parav Pandit wrote: > > > > > What do you suggest? > > > > > > > > Start with real patches, not netdevsim. > > > > > > Hmm. Shall I split the series below, would that be ok? > > > > > > First patchset, > > > (a) devlink piece to add/delete port > > > (b) mlx5 counter part > > > > > > Second patchset, > > > (a) devlink piece to set the state > > > (b) mlx5 counter part > > > > > > Follow on patchset to create/delete sf's netdev on virtbus in mlx5 + > > > devlink > > plumbing. > > > Netdevsim after that. > > > > I'd start from the virtbus part so we can see what's being created. > > How do you reach there without a user interface?
Well.. why do you have a user interface which doesn't cause anything to happen (devices won't get created)? You're splitting the submission, it's obvious the implementation won't be complete after the first one. My expectation is that your implementation of the devlink commands will just hand them off to FW, so there won't be anything interesting there to review. Start with the hard / risky parts - I consider the virtbus to be that, since the conversation there includes multiple vendors, use cases and subsystems.
