On Thu, 24 Jan 2019 15:16:27 +0530, Vasundhara Volam wrote: > > > > The devlink WoL setting does not have to match the ethtool WoL > > > > setting. > > > > > > IMHO this is not really a problem. We can either use an additional flag > > > telling kernel/driver if we are setting runtime or persistent WoL mask > > > or we can pass (up to) two bitmaps. > > > > I think reusing new netlink ethtool with a special flag would be a nice, > > complete solution. We could also address link settings this way (which > > are a pre-requisite for WoL). > > > > I have no strong preference on the mechanism, but for ease of setting > > as well as dumping would it be workable to use a nesting, like this: > > > > Run time settings: > > [ETHTOOL_SETTINGS_BLA] > > [ETHTOOL_BLA_VAL_1] > > [ETHTOOL_BLA_VAL_2] > > ... > > > > Persistent: > > [ETHTOOL_PERSISTENT] > > [ETHTOOL_SETTINGS_BLA] > > [ETHTOOL_BLA_VAL_1] > > [ETHTOOL_BLA_VAL_2] > > > > IOW encapsulate settings into a "persistent" attribute? > Not sure if current devlink framework allows to encapsulate additional > settings now. > But we can think of extending it to support this when there is a requirement.
To be clear the question was to Michal and about ethtool netlink, where this configuration belongs.
