Re: [PATCH net-next 4/5] net: dsa: mv88e6xxx: Add helper to determining if port has SERDES

[Vivien Didelot]

Hi Andrew,

Andrew Lunn <and...@lunn.ch> writes:

> -int mv88e6352_serdes_power(struct mv88e6xxx_chip *chip, int port, bool on)
> +static int mv88e6352_port_has_serdes(struct mv88e6xxx_chip *chip, int port)
>  {
> -     int err;
>       u8 cmode;
> +     int err;
>  
>       err = mv88e6xxx_port_get_cmode(chip, port, &cmode);
> -     if (err)
> -             return err;
> +     if (err) {
> +             dev_err(chip->dev, "failed to read cmode\n");
> +             return 0;
> +     }
>  
>       if ((cmode == MV88E6XXX_PORT_STS_CMODE_100BASE_X) ||
>           (cmode == MV88E6XXX_PORT_STS_CMODE_1000BASE_X) ||
> -         (cmode == MV88E6XXX_PORT_STS_CMODE_SGMII)) {
> +         (cmode == MV88E6XXX_PORT_STS_CMODE_SGMII))
> +             return 1;
> +
> +     return 0;
> +}

Please use a bool for such helpers.


Thanks,

        Vivien