Mon, Nov 27, 2017 at 08:42:49PM CET, jakub.kicin...@netronome.com wrote: >On Tue, 28 Nov 2017 04:30:26 +0900 (KST), David Miller wrote: >> From: Jakub Kicinski <jakub.kicin...@netronome.com> >> Date: Thu, 23 Nov 2017 18:36:11 -0800 >> >> > The dummy driver have previously been extended to test SR-IOV, >> > but the general consensus seems to be against adding further >> > features to it. >> >> I guess this is fine, but then is it going to be the case that >> every time we want to add a software offload implementation for >> testing driver paths we add yet another dummy driver? > >I would expect others to extend the netdevsim driver, so all test/SW >implementation would live there. > >I was considering moving the SR-IOV code over, too, but I'm worried
Agreed. Leave dummy be dummy. netdevsim should serve this purpose. Thanks! >I will break existing tests. Phil, Sabrina would you be OK with that?