From: Herbert Xu <[EMAIL PROTECTED]> Date: Sat, 15 Jul 2006 23:28:34 +1000
> At least this lets us get rid of a few other memsets :) > > [IPV4]: Get rid of redundant IPCB->opts initialisation > > Now that we always zero the IPCB->opts in ip_rcv, it is no longer > necessary to do so before calling netif_rx for tunneled packets. > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Applied, good spotting :-) I remember when we added those things. But I'm beginning to think that the onus of this may in fact fall upon the devices, in fact. Loopback is one of the few devices where the control block might not be cleared out, due to uses in the output path. Devices predominantly provide a zero'd out control block in the skb on packet receive. And the memset() cases we're removing here with Herbert's change are the other exceptional cases, such as tunnels that decapsulate the IPV4 protocol. Other opinions welcome... - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
