On Thu, Nov 10, 2016 at 1:47 AM, Jiri Benc <jb...@redhat.com> wrote: > On Wed, 9 Nov 2016 19:33:24 -0800, Pravin Shelar wrote: >> I have moved the dst error handling to vxlan_build_skb(), which is >> releasing the dst entry. > > Hmm, right, I missed that. But it's weird. The previous logic was > confusing (skb is freed in case of error but not otherwise), I'm with > you on this change. But having the same confusing logic with dst_entry > instead doesn't improve things. > > Could we free both skb and dst_entry from the caller? >
I wanted to do same, that is free dst and skb in caller function. But that would need more changes due to discrepancy in IPv4 udp-tunnel and IPv6 udp-tunnel api. IPv4 works on route entry and IPv6 needs dst entry. so If caller frees dst-entry then I need additional variable to keep track of dst entry which is what I am trying to avoid.
