On Wed, 9 Nov 2016 19:35:00 -0800, Pravin Shelar wrote: > On Wed, Nov 9, 2016 at 8:59 AM, Jiri Benc <jb...@redhat.com> wrote: > > Uninitialized old_iph. > > > It is initialized in begining of this function.
Right you are, sorry. > TOS and TTL is initialized for LWT just else block. so I do not see > any changes compared to current implementation. Oh, right. We set them unconditionally from tunnel_info. I was convinced we fallback to the interface config values when they're not given and stopped reviewing the patch but we don't. This is a nice cleanup, thanks! Acked-by: Jiri Benc <jb...@redhat.com>