On Wed, Jan 18, 2006 at 02:15:37PM -0800, Kris Katterjohn wrote:
>  
>  #include <linux/module.h>
>  #include <linux/types.h>
> -#include <linux/sched.h>

OK.

> -#include <linux/mm.h>

Needed for GFP_*.  Replace this with gfp.h if you want.

> -#include <linux/fcntl.h>
> -#include <linux/socket.h>
> -#include <linux/in.h>
> -#include <linux/inet.h>

OK.

> -#include <linux/netdevice.h>

We need this for skb->dev->ifindex.

> -#include <linux/if_packet.h>
> -#include <net/ip.h>
> -#include <net/protocol.h>

OK.

> -#include <linux/timer.h>

OK, but you should add linux/spinlock.h.

> -#include <asm/system.h>
> +#include <asm/atomic.h>
> +#include <asm/bug.h>
> +#include <asm/byteorder.h>

Looks good.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to