On 1/18/06, Herbert Xu <[EMAIL PROTECTED]> wrote: > On Wed, Jan 18, 2006 at 04:55:39PM -0800, Kris Katterjohn wrote: > > > > > > -#include <linux/netdevice.h> > > > > > > We need this for skb->dev->ifindex. > > > > But we know we have struct net_device because it's used in linux/skbuff.h > > (for > > skb->dev of course). I'm not saying it doesn't make sense, just that it > > seems to > > me that it's probably not needed. No matter, though. > > You can't rely on that because linux/skbuff.h may only provide a forward > declaration for the structure.
Yes, but its good to see more people taming the includes hell :-) You may find a script I wrote long ago useful in these endeavours, it basicaly uses graphviz to give you a picture of the includes hell, as this one I did recently: http://oops.ghostprotocols.net:81/acme/tcp.h.ps The scripts are hviz and ghviz, available at my kernel.org area. - Arnaldo - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
