On Thu, 2005-29-12 at 17:08 +0100, Patrick McHardy wrote:
> jamal wrote:
> > On Wed, 2005-28-12 at 18:19 +0100, Patrick McHardy wrote:
> > Its one of those 50/50 decisions - I could create a new device,
> > what would you think for a name?
>
> IMQ? :) No, I'm bad coming up with names myself ..
>
I will think of something. But it seems like after talking to
other people as well, the consensus is agreeing with you. I will create
a new device instead of abusing dummy ;->
>
> Doesn't the blackholing conflict with this new use?
>
> + __u32 from = G_TC_FROM(skb->tc_verd);
> + if (!from || !skb->input_dev ) {
>
> In dev_queue_xmit both from and input_dev should be set even
> for normal blackholed packets, unless I'm missing something.
>
If the packets are coming from the stack (user space for example
downwards), they should never be set.
This is the majority use of dummy. And so things would work as before.
> Yes, but that means I need to search for the comments if I want to
> know what "rqe" is. You can eliminate the need for the comments
> by using more descriptive names.
>
ok, fine i will change these as well
>
> I'd say just kill the comment, I don't see any advantage in using
> netfilter for this.
I agree - so will kill that comment.
I have to run out for a few hours. When i come back i will create the
new device, test and post the patch.
cheers,
jamal
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
