On Fri, 30 Oct 2026 16:47:03 GMT, Daniel Fuchs <[email protected]> wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Move test cases to PacketNumbersTest
>
> test/jdk/java/net/httpclient/quic/PacketNumbersTest.java line 45:
>
>> 43: record EncodeResult(String expected, boolean assertion, Class<?
>> extends Throwable> failure) {
>> 44: public static EncodeResult illegal() {
>> 45: return new EncodeResult(null, true,
>> IllegalArgumentException.class);
>
> I know this is pre-existing but shouldn't this be:
>
> Suggestion:
>
> return new EncodeResult(null, false,
> IllegalArgumentException.class);
>
>
> Do we really need system assertions enabled to run the `illegal` test cases?
Well spotted. I don't think we do. I'll clear that up.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33646#discussion_r4426224018
