On Fri, 30 Oct 2026 14:16:37 GMT, Daniel Jeliński <[email protected]> wrote:
>> The test covers the same RFC-provided cases as the >> [PacketNumbersTest](https://github.com/openjdk/jdk/blob/2d9c668378b9cf6450100464e7a6c6fadfd42dc0/test/jdk/java/net/httpclient/quic/PacketNumbersTest.java), >> see RFC 9000 appendix A.2 and A.3. It's also the only test in its >> subdirectory, and is not listed in any test groups. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Daniel Jeliński has updated the pull request incrementally with one > additional commit since the last revision: > > Move test cases to PacketNumbersTest test/jdk/java/net/httpclient/quic/PacketNumbersTest.java line 45: > 43: record EncodeResult(String expected, boolean assertion, Class<? > extends Throwable> failure) { > 44: public static EncodeResult illegal() { > 45: return new EncodeResult(null, true, > IllegalArgumentException.class); I know this is pre-existing but shouldn't this be: Suggestion: return new EncodeResult(null, false, IllegalArgumentException.class); Do we really need system assertions enabled to run the `illegal` test cases? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33646#discussion_r4426131038
