On Mon, 12 Oct 2026 12:55:14 GMT, Matthias Baesken <[email protected]> wrote:

> `src/java.base/windows/native/libnet/ResolverConfigurationImpl.c` has 3 
> unused macros defined: `IS_SL_FOUND`, `IS_NS_FOUND`, and `STS_NO_CONFIG`.
> 
> Plus, `loadConfig()` returns `STS_SL_FOUND & STS_NS_FOUND`, which is always 
> 0. `&` usage looks wrong.
> However the strange return value is no big issue because we currently only 
> check for error (-1), and this still works.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

This pull request has now been integrated.

Changeset: 11fe5238
Author:    Matthias Baesken <[email protected]>
URL:       
https://git.openjdk.org/jdk/commit/11fe52380c5f20f2aada3d69924a7760d6d9c0e3
Stats:     13 lines in 1 file changed: 1 ins; 8 del; 4 mod

8394134: ResolverConfigurationImpl.c has unused macros and potential typo in 
returned value of loadConfig (win)

Reviewed-by: djelinski

-------------

PR: https://git.openjdk.org/jdk/pull/33318

Reply via email to