On Thu, 15 Oct 2026 14:42:30 GMT, Matthias Baesken <[email protected]> wrote:
>> `src/java.base/windows/native/libnet/ResolverConfigurationImpl.c` has 3 >> unused macros defined: `IS_SL_FOUND`, `IS_NS_FOUND`, and `STS_NO_CONFIG`. >> >> Plus, `loadConfig()` returns `STS_SL_FOUND & STS_NS_FOUND`, which is always >> 0. `&` usage looks wrong. >> However the strange return value is no big issue because we currently only >> check for error (-1), and this still works. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > loadConfig returns now BOOL src/java.base/windows/native/libnet/ResolverConfigurationImpl.c line 42: > 40: #define STS_NS_FOUND 0x2 /* name servers found */ > 41: #define STS_ERROR -1 /* error return lodConfig > failed memory allccation failure*/ > 42: Suggestion: ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33318#discussion_r4284493734
