On Mon, 10 Aug 2026 11:32:41 GMT, Jaikiran Pai <[email protected]> wrote:
>> Volkan Yazici has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'upstream/master' into hsDrainAmount
>> - Convert `NoContentReturningHandler` to a class
>> - Fix comment on `SocketException("EOF")`
>> - Fix `@bug` tags
>> - Fix the `eof` handling in `FixedLengthInputStream`
>
> test/jdk/com/sun/net/httpserver/property/DrainAmountPropertyTest.java line 44:
>
>> 42: /*
>> 43: * @test id=default
>> 44: * @bug 8295785
>
> Should this instead be `8387853`?
Fixed in 2d7a25933fe.
> test/jdk/com/sun/net/httpserver/property/DrainAmountPropertyTest.java line 54:
>
>> 52: /*
>> 53: * @test id=negative
>> 54: * @bug 8295785 8387853
>
> Maybe remove the reference to 8295785?
Fixed in 2d7a25933fe.
> test/jdk/com/sun/net/httpserver/property/DrainAmountPropertyTest.java line
> 184:
>
>> 182: if (nextChar < 0) {
>> 183: // `SocketException` is caught to detect the peer
>> disconnect
>> 184: throw new SocketException("EOF");
>
> Where does this exception get caught?
It is indeed not get caught. We throw, since the peer disconnect is not
expected. I've updated the comment to reflect that in a07b19ff8b7.
> test/jdk/com/sun/net/httpserver/property/DrainAmountPropertyTest.java line
> 197:
>
>> 195: }
>> 196:
>> 197: private enum NoContentReturningHandler implements HttpHandler {
>> INSTANCE;
>
> I think it would be clearer to use a `class` for the `HttpHandler`
> implementation. It took me a while to notice that this was an `enum` after I
> kept staring at the `INSTANCE;` at the end of this line.
Converted to a class in 456021f21a3.
_"And it came to pass that a great weeping fell upon the land, for the children
of tech did turn their hearts away from the One True Pattern. Verily, they did
forsake the Holy Singleton, that sacred incantation cast down from the heavens
in blinding beams of light by the prophets of Effective Java."_ — Joshua 3:1
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32234#discussion_r3755991990
PR Review Comment: https://git.openjdk.org/jdk/pull/32234#discussion_r3755991602
PR Review Comment: https://git.openjdk.org/jdk/pull/32234#discussion_r3755991096
PR Review Comment: https://git.openjdk.org/jdk/pull/32234#discussion_r3755990458
