On Thu, 6 Aug 2026 09:56:17 GMT, Volkan Yazici <[email protected]> wrote:

> Ensure `HttpServer` doesn't close connection after zero-length requests.
> 
> ---------
> - [X] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

test/jdk/com/sun/net/httpserver/property/DrainAmountPropertyTest.java line 184:

> 182:             if (nextChar < 0) {
> 183:                 // `SocketException` is caught to detect the peer 
> disconnect
> 184:                 throw new SocketException("EOF");

Where does this exception get caught?

test/jdk/com/sun/net/httpserver/property/DrainAmountPropertyTest.java line 197:

> 195:     }
> 196: 
> 197:     private enum NoContentReturningHandler implements HttpHandler { 
> INSTANCE;

I think it would be clearer to use a `class` for the `HttpHandler` 
implementation. It took me a while to notice that this was an `enum` after I 
kept staring at the `INSTANCE;` at the end of this line.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32234#discussion_r3749111763
PR Review Comment: https://git.openjdk.org/jdk/pull/32234#discussion_r3749125459

Reply via email to