On Fri, 31 Jul 2026 13:35:30 GMT, Jaikiran Pai <[email protected]> wrote:

> Can I please get a review of this change which removes the `deregistrations` 
> field from an internal class of the `HttpClient`?
> 
> As noted in https://bugs.openjdk.org/browse/JDK-8389514, this collection 
> never gets populated and as a result the call sites which `clear()` or 
> iterate over this collection are all dead code. It has been this way ever 
> since this field was introduced in Java 11 through 
> https://bugs.openjdk.org/browse/JDK-8197564.
> 
> I'm running existing tests to verify that nothing breaks unexpectedly.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Good cleanup. LGTM.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/32152#pullrequestreview-4829378834

Reply via email to