Can I please get a review of this change which removes the `deregistrations` 
field from an internal class of the `HttpClient`?

As noted in https://bugs.openjdk.org/browse/JDK-8389514, this collection never 
gets populated and as a result the call sites which `clear()` or iterate over 
this collection are all dead code. It has been this way ever since this field 
was introduced in Java 11 through https://bugs.openjdk.org/browse/JDK-8197564.

I'm running existing tests to verify that nothing breaks unexpectedly.

---------
- [x] I confirm that I make this contribution in accordance with the [OpenJDK 
Interim AI Policy](https://openjdk.org/legal/ai).

-------------

Commit messages:
 - 8389514: HttpClientImpl$SelectorManager.deregistrations collection is always 
empty resulting in dead code

Changes: https://git.openjdk.org/jdk/pull/32152/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=32152&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8389514
  Stats: 9 lines in 1 file changed: 0 ins; 8 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/32152.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/32152/head:pull/32152

PR: https://git.openjdk.org/jdk/pull/32152

Reply via email to