On Fri, 26 Jun 2026 13:38:01 GMT, Daniel Fuchs <[email protected]> wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/quic/QuicTimerQueue.java >> line 124: >> >>> 122: assert QuicTimedEvent.COMPARATOR.compare(event, CEILING) < 0; >>> 123: Deadline deadline = event.deadline(); >>> 124: rescheduled.add(event); >> >> With this change, `offer(event)` implementation can be simplified to >> `reschedule(event,event.deadline())` > > Right. But I wanted to preserve the slightly different tracing. This method > is supposed to be called when the event is not yet scheduled. Though, as we > observed, it can be difficult to assert - hence the used of the `rescheduled` > set here instead of `scheduled`. which tracing differences would you like to preserve? Keeping a 30+ line method just for a debug log entry feels like overkill. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31693#discussion_r3481808361
