On Thu, 11 Dec 2025 13:01:53 GMT, Daniel Fuchs <[email protected]> wrote:
>> Overhauls `SimpleSSLContext` to remove the need for null checks at the call >> site, and to accept a key store file search path, which removes the need to >> copy-paste `SimpleSSLContext` just to change the search path. >> >> ### Tips for reviewers >> >> 1. Start from `SimpleSSLContext.java` >> 2. See how >> `test/jdk/java/net/httpclient/whitebox/java.net.http/jdk/internal/net/http/SimpleSSLContext.java` >> is renamed to >> `test/jdk/java/net/httpclient/whitebox/java.net.http/jdk/internal/net/http/SimpleSSLContextWhiteboxAdapter.java` >> and how `@compile/module=java.net.http .../SimpleSSLContext.java` JTreg tag >> is used to inject `SimpleSSLContext` > > I would prefer to split this PR into two fixes: > > - a first fix that simply adds the new API to SimpleSSLContext, without > removing the old API. > - a second fix that do all the rest: remove the old API and update the tests. > > This would allow us to easily backport the first fix, and new tests would not > need adaptation when they are later being backported provided that the first > fix has been backported first. > > You could enjoy using dependent PRs for this :-) @dfuch, I've updated the ticket and this PR as follows: 1. Pushed d4c9b3129fc reverting all changes and only keeping `SimpleSSLContext` enhancements, and updated the parent ticket description (i.e., [JDK-8372661]) to reflect this. 2. Created [JDK-8373515] for migrating `test/jdk/java/net/httpclient/` 3. Created [JDK-8373537] for migrating `test/jdk/com/sun/net/httpserver/` 4. Created [JDK-8373538] for migrating the rest, and removing the unused `SimpleSSLContext` methods [JDK-8372661]: https://bugs.openjdk.org/browse/JDK-8372661 [JDK-8373515]: https://bugs.openjdk.org/browse/JDK-8373515 [JDK-8373537]: https://bugs.openjdk.org/browse/JDK-8373537 [JDK-8373538]: https://bugs.openjdk.org/browse/JDK-8373538 ------------- PR Comment: https://git.openjdk.org/jdk/pull/28765#issuecomment-3643196386
