On Thu, 11 Dec 2025 09:45:54 GMT, Volkan Yazici <[email protected]> wrote:
> Overhauls `SimpleSSLContext` to remove the need for null checks at the call > site, and to accept a key store file search path, which removes the need to > copy-paste `SimpleSSLContext` just to change the search path. > > ### Tips for reviewers > > 1. Start from `SimpleSSLContext.java` > 2. See how > `test/jdk/java/net/httpclient/whitebox/java.net.http/jdk/internal/net/http/SimpleSSLContext.java` > is renamed to > `test/jdk/java/net/httpclient/whitebox/java.net.http/jdk/internal/net/http/SimpleSSLContextWhiteboxAdapter.java` > and how `@compile/module=java.net.http .../SimpleSSLContext.java` JTreg tag > is used to inject `SimpleSSLContext` I would prefer to split this PR into two fixes: - a first fix that simply adds the new API to SimpleSSLContext, without removing the old API. - a second fix that do all the rest: remove the old API and update the tests. This would allow us to easily backport the first fix, and new tests would not need adaptation when they are later being backported provided that the first fix has been backported first. You could enjoy using dependent PRs for this :-) ------------- PR Comment: https://git.openjdk.org/jdk/pull/28765#issuecomment-3641822078
