On Thu, 11 Dec 2025 09:21:41 GMT, Daniel Fuchs <[email protected]> wrote:
>> Volkan Yazici has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 18 commits:
>>
>> - Pull changes from upstream
>> - Merge remote-tracking branch 'upstream/master' into firstValueAsLong
>> - Close connection after `Content-Length` read failure in `Http1Response`
>> - Insert the redundant `Http3Stream` assert back
>> - Introduce dangling `firstValueAsLong("content-length")` calls back
>> - Document `Http1Response::ignoreBody`
>> - Remove redundant `finally`
>> - Use `-1` as default in `Http3ExchangeImpl`
>> - Use `readStatusCode()` in `Http3Stream`
>> - Replace `orElse(null)` with `Optional` usage
>> - ... and 8 more: https://git.openjdk.org/jdk/compare/786833cd...b677820c
>
> src/java.net.http/share/classes/jdk/internal/net/http/Http3ExchangeImpl.java
> line 1303:
>
>> 1301: promiseHeaders, "illegal push headers for pushId=%s:
>> ".formatted(pushId), -1);
>> 1302: if (clen > 0) {
>> 1303: throw new ProtocolException("push headers contain non-zero
>> \"Content-Length\" for pushId=" + pushId);
>
> Nit - the exception for Transfer-Encoding below doesn't have double quotes
> around Transfer-Encoding. I don't mind adding double quotes here but maybe
> they should be added below too for consistency.
Double-quoted `Transfer-Encoding` in 1d136049050.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28431#discussion_r2610930631
