On Mon, 1 Dec 2025 10:46:37 GMT, Daniel Fuchs <[email protected]> wrote:
>> Volkan Yazici has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 17 additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'upstream/master' into firstValueAsLong
>> - Close connection after `Content-Length` read failure in `Http1Response`
>> - Insert the redundant `Http3Stream` assert back
>> - Introduce dangling `firstValueAsLong("content-length")` calls back
>> - Document `Http1Response::ignoreBody`
>> - Remove redundant `finally`
>> - Use `-1` as default in `Http3ExchangeImpl`
>> - Use `readStatusCode()` in `Http3Stream`
>> - Replace `orElse(null)` with `Optional` usage
>> - Address review remarks
>> - ... and 7 more: https://git.openjdk.org/jdk/compare/1d684a33...02803082
>
> src/java.net.http/share/classes/jdk/internal/net/http/Http3Stream.java line
> 630:
>
>> 628: finalResponse = true;
>> 629: } else {
>> 630: assert responseCode >= 100 && responseCode <= 200 :
>> "unexpected responseCode: " + responseCode;
>
> Can we keep the assert?
Inserted back in b2074e3379f.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28431#discussion_r2588965325
