On Wed, 12 Nov 2025 10:11:22 GMT, Volkan Yazici <[email protected]> wrote:

>> src/java.net.http/share/classes/jdk/internal/net/http/Http2TerminationCause.java
>>  line 84:
>> 
>>> 82:      * such cases.
>>> 83:      */
>>> 84:     public abstract boolean isErroneousClose();
>> 
>> nit: can we use a different word here? "Erroneous close" feels vague here; 
>> would "is(Non)Graceful", "isAbrupt" or "hasErrorCode" capture the intent?
>
> That that `erroneous close` has been used in several other contexts; in code, 
> in comments, etc. If this gets updated, I'd appreciate other relevant 
> occurrences get updated too.

Would `isAbnormalClose()` be better?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28233#discussion_r2533617843

Reply via email to