On Tue, 11 Nov 2025 13:17:18 GMT, Daniel Fuchs <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - mark jdk.internal.net.http.Http2Connection as Closable
>> - reduce number of concurrent requests
>
> src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java
> line 912:
>
>> 910: * Closes the connection normally (with a NO_ERROR termination
>> cause), if not already closed.
>> 911: */
>> 912: final void close() {
>
> Maybe we should mark the Http2Connection as Closeable.
I think that's reasonable. I've updated the PR to include this change.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28233#discussion_r2514406165
