Re: RFR: 8208693: HttpClient: Extend the request timeout's scope to cover the response body [v7]

[Daniel Fuchs]

On Mon, 3 Nov 2025 12:24:50 GMT, Volkan Yazici <vyaz...@openjdk.org> wrote:

>> Currently `HttpRequest::timeout` only applies until the response headers are 
>> received. Extend its scope to also cover the consumption of the response 
>> body.
>> 
>> ### Review guidelines
>> 
>> 1. Read _"the fix"_ in `MultiExchange`
>> 2. Skim through the test server *handler* in `TimeoutResponseTestSupport`
>> 3. Review first `TimeoutResponseHeaderTest`, and then 
>> `TimeoutResponseBodyTest` (Mind the multiple `@test` blocks!)
>
> Volkan Yazici has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Simplify Javadoc

src/java.net.http/share/classes/java/net/http/HttpClient.java line 321:

> 319:          * @throws IllegalArgumentException if the duration is 
> non-positive
> 320:          * @see HttpRequest.Builder#timeout(Duration) Configuring 
> timeout for
> 321:          * request execution

Did you verify what javadoc generated for that?

src/java.net.http/share/classes/jdk/internal/net/http/MultiExchange.java line 
256:

> 254:     }
> 255: 
> 256:     public void cancelTimer() {

We could leave that package private.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27469#discussion_r2486358857
PR Review Comment: https://git.openjdk.org/jdk/pull/27469#discussion_r2486374196